Re: [PATCH] kbuild: Do not reference *-n variables in the Makefile

From: Masahiro Yamada
Date: Thu Oct 02 2014 - 09:55:31 EST


Hi Michal,

On Thu, 02 Oct 2014 15:35:35 +0200
Michal Marek <mmarek@xxxxxxx> wrote:

> On 2014-10-02 15:33, Michal Marek wrote:
> > Kconfig options are either 'y', 'm', or undefined.
> >
> > Signed-off-by: Michal Marek <mmarek@xxxxxxx>
> > ---
> > Makefile | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index efbd2cb..106f300 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -868,9 +868,7 @@ vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
> > $(net-y) $(net-m) $(libs-y) $(libs-m)))
> >
> > vmlinux-alldirs := $(sort $(vmlinux-dirs) $(patsubst %/,%,$(filter %/, \
> > - $(init-n) $(init-) \
> > - $(core-n) $(core-) $(drivers-n) $(drivers-) \
> > - $(net-n) $(net-) $(libs-n) $(libs-))))
> > + $(init-) $(core-) $(drivers-) $(net-) $(libs-))))
>
> Actually, all the directories are hardcoded in
> {init,code,drivers,net,libs}-y; there are currently no Kconfig variables
> involved. But let's keep this generic and handle *-m and *- just in case.
>

Agreed and thank you!

Best Regards
Masahiro Yamada

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/