Re: [BUG] perf tools: off-by-one error in map_groups__find_ams()

From: Stephane Eranian
Date: Thu Oct 02 2014 - 12:40:25 EST


On Thu, Oct 2, 2014 at 10:36 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> On Wed, Oct 01, 2014 at 09:16:31PM +0200, Stephane Eranian wrote:
>> Hi,
>>
>> It appears that there is a off-by-one bug in map_groups__find_ams().
>> The upper-bound check in the test below should be >= because
>> end = start + len; The end address is outside the range.
>>
>> Please confirm.
>>
>>
>> int map_groups__find_ams(struct addr_map_symbol *ams, symbol_filter_t filter)
>> {
>> if (ams->addr < ams->map->start || ams->addr > ams->map->end) {
>
> yep, looks like bug to me
>
Are you providing a fix or should I?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/