RE: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM

[Hartley Sweeten]

On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote:
> COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> with allmodconfig under um):
>
>     CC [M]  drivers/staging/comedi/drivers/ii_pci20kc.o
>   drivers/staging/comedi/drivers/ii_pci20kc.c: In function âii20k_attachâ:
>   drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function âioremapâ [-Werror=implicit-function-declaration]
>     dev->mmio = ioremap(membase, II20K_SIZE);
>     ^
>   drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default]
>     dev->mmio = ioremap(membase, II20K_SIZE);
>               ^
>   drivers/staging/comedi/drivers/ii_pci20kc.c: In function âii20k_detachâ:
>   drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function âiounmapâ [-Werror=implicit-function-declaration]
>      iounmap(dev->mmio);
>      ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>
> ---
>  drivers/staging/comedi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index a8bc2b5..b709736 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16
>  
>  config COMEDI_II_PCI20KC
>  	tristate "Intelligent Instruments PCI-20001C carrier support"
> +	depends on HAS_IOMEM
>  	---help---
>  	  Enable support for Intelligent Instruments PCI-20001C carrier
>  	  PCI-20001, PCI-20006 and PCI-20341

This seems appropriate.

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ0¶ìå