Re: [PATCH v3 2/2] tile: add clock_gettime support to vDSO

[John Stultz]

On Thu, Oct 2, 2014 at 7:32 AM, Chris Metcalf <cmetcalf@xxxxxxxxxx> wrote:
> This change adds support for clock_gettime with CLOCK_REALTIME
> and CLOCK_MONOTONIC using vDSO.  It also updates the vdso
> struct nomenclature used for the clocks to match the x86 code
> to keep it easier to update going forward.
>
> We also support the *_COARSE clockid_t, for apps that want speed
> but aren't concerned about fine-grained timestamps; this saves
> about 20 cycles per call (see http://lwn.net/Articles/342018/).
>
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> ---
>  arch/tile/include/asm/vdso.h          |  15 ++--
>  arch/tile/kernel/time.c               |  45 ++++++++---
>  arch/tile/kernel/vdso/vdso.lds.S      |   2 +
>  arch/tile/kernel/vdso/vgettimeofday.c | 145 +++++++++++++++++++++++++++++-----
>  4 files changed, 172 insertions(+), 35 deletions(-)
>
> v2: use the x86 code as a model to address both John Stultz's
>     observation about sub-nanosecond updates, as well as to address
>     Thomas Gleixner's observation about minimizing time spent with
>     the seqlock held.  Note that I kept the "unlikely" that Thomas
>     doubted would help, just for parallelism with the x86 code.
> v3: rebase onto 3.17-rc7


Looks ok to me.

Acked-by: John Stultz <john.stultz@xxxxxxxxxx>

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/