Re: [PATCH v2 0/3] i2c: designware: Add support for AMD I2C controller
From: Wolfram Sang
Date: Thu Oct 02 2014 - 20:46:18 EST
On Tue, Sep 30, 2014 at 01:04:52PM +0300, Mika Westerberg wrote:
> This is second iteration of the patch series. First version is here:
>
> http://patchwork.ozlabs.org/patch/390694/
> http://patchwork.ozlabs.org/patch/390695/
>
> In order to get source clock to the core driver we need some way of
> creating it in the first place. For Intel LPSS it is done in
> drivers/acpi/acpi_lpss.c but that is not applicable for AMD I2C host
> controller which is too different from private parts to the LPSS one.
>
> We solve this by creating the clock in ACPI parts of the platform driver
> when we detect the AMD I2C host controller. Doing this requires small
> refactoring to be done to the probe() which is what patches [1-2/3] are
> doing.
>
> Changes to the previous version:
> * Rebased on top of i2c/for-next branch
> * New patch defaulting ACPI probe to fast mode
> * Instead of direct dependency to COMMON_CLK we depend on (ACPI &&
> COMMON_CLK) || ACPI. (suggested by Wolfram)
>
> Carl, can you test that this still works on your machine?
Yes, Carl that would be helpful.
Patches look good to me.
Thanks!
Attachment:
signature.asc
Description: Digital signature