Re: [PATCH 2/2] perf, x86: Use INTEL_FLAGS_UEVENT_CONSTRAINT for PRECDIST

[Ingo Molnar]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Wed, Sep 10, 2014 at 04:22:32PM +0200, Peter Zijlstra wrote:
> > On Wed, Sep 10, 2014 at 07:02:58AM -0700, Andi Kleen wrote:
> > > On Wed, Sep 10, 2014 at 09:59:26AM +0200, Peter Zijlstra wrote:
> > > > On Tue, Sep 09, 2014 at 05:49:08PM -0700, Andi Kleen wrote:
> > > > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > > > 
> > > > > The earlier commit 86a04461a made near all PEBS on
> > > > > Sandy/IvyBridge/Haswell to reject non zero flags.
> > > > 
> > > > What's magic about nehalem and westmere?
> > > 
> > > I wasn't able to confirm their behavior explicitly, so I felt
> > > it best to leave them alone.
> > > 
> > > But in principle adding the _FLAGS changes there too would
> > > make sense too.
> > 
> > Yeah please do that patch ASAP, having PEBS behave differently across
> > uarchs is wrong.
> 
> Ping!

Also, I have to NAK this patch for trivial style reasons: the 
patch adds gobs of misaligned, misplaced spaces instead of using 
proper tabs - and apparently that's not the first time Andi did 
that to the constraints tables.

This is annoying and ineffective and Andi Kleen continues to 
introduce trivial flaws into the kernel despite repeated 
complaints and requests for him to use available tools to check 
patch quality such as scripts/checkpatch.pl.

As a result I'm dropping most patches from Andi in the perf/core 
pipeline and I will delay them to at least until v3.19 when I 
might have more time to waste on reviewing trivially flawed 
patches.

I only took this single patch:

  perf/x86/intel/uncore: Fix minor race in box set up

which fixes a bug, and I've dropped all other patches from Andi.

Next time I see trivial flaws in Andi's patches I'll drop and 
delay them for two cycles, not one, to give them ample time to be 
improved.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/