Re: [RFC PATCH 05/16] arm64: support poweroff through poweroff handler call chain

[Guenter Roeck]

On 10/03/2014 03:30 AM, Catalin Marinas wrote:
> On Tue, Sep 30, 2014 at 07:00:45PM +0100, Guenter Roeck wrote:
> > The kernel core now supports a poweroff handler call chain
> > to remove power from the system. Call it if pm_power_off
> > is set to NULL.
> >
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will.deacon@xxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> >   arch/arm64/kernel/process.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> > index 398ab05..cc0c63e 100644
> > --- a/arch/arm64/kernel/process.c
> > +++ b/arch/arm64/kernel/process.c
> > @@ -157,6 +157,8 @@ void machine_power_off(void)
> >   	smp_send_stop();
> >   	if (pm_power_off)
> >   		pm_power_off();
> > +	else
> > +		do_kernel_poweroff();
>
> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
>
> As others already stated, I think we should eventually remove
> pm_power_off entirely.

Hi Catalin,
yes, already working on it. As suggested by others, I'll move pm_power_off
to a central location (no need to declare the same variable for each
architecture) and hide the call to it in do_kernel_poweroff() as a
first step. You'll see this in the next version of the series.
This will make it much easier to remove it later on.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/