Re: Why do we still have 32 bit counters? Interrupt counters overflow within 50 days

From: Christoph Lameter
Date: Fri Oct 03 2014 - 10:04:47 EST


> Fine, but the subject line sounded different.

Hmmm.... Found a bug. We need this patch on top

Subject: Fix allocpercpu

Must allocate unsigned long not int.

Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

Index: linux/kernel/irq/irqdesc.c
===================================================================
--- linux.orig/kernel/irq/irqdesc.c
+++ linux/kernel/irq/irqdesc.c
@@ -140,7 +140,7 @@ static struct irq_desc *alloc_desc(int i
if (!desc)
return NULL;
/* allocate based on nr_cpu_ids */
- desc->kstat_irqs = alloc_percpu(unsigned int);
+ desc->kstat_irqs = alloc_percpu(unsigned long);
if (!desc->kstat_irqs)
goto err_desc;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/