Re: [PATCH RFC] introduce ioctl to completely invalidate page cache

[Jens Axboe]

On 2014-10-03 03:25, Thanos Makatos wrote:
> > > -		fsync_bdev(bdev);
> > > -		invalidate_bdev(bdev);
> > > +		flush_buffer_cache(bdev);
> > > +		if (BLKFLSBUF2 == cmd)
> > > +			return invalidate_inode_pages2(
> > > +					bdev->bd_inode->i_mapping);
> > >   		return 0;
> >
> > We're currently ignoring the buffer cache sync and invalidation (which is odd),
> > but at least being consistent would be good.
> >
> > Might also need a filemap_write_and_wait() to sync before invalidation.
>
> (I've got zero knowledge in this area, so excuse my ignorance!)
>
> Does filemap_write_and_wait() writes back modified, memory-mapped pages? If so,
> isn't there a race condition? Or have I got it completely wrong?

There's no race to be concerned of for this ioctl. Any page dirtied 
before you make the call will be synced, any page dirtied after may not. 
This is no different than what would happen on the buffer cache side in 
the current ioctl.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/