Re: [PATCH v2 2/2] workqueue: use cond_resched_rcu_qs macro

[Paul E. McKenney]

On Sun, Oct 05, 2014 at 01:24:22PM -0400, Joe Lawrence wrote:
> Tidy up and use cond_resched_rcu_qs when calling cond_resched and
> reporting potential quiescent state to RCU.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxxx>

Reviewed-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

> ---
>  kernel/workqueue.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 345bec9..09b685d 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2046,8 +2046,7 @@ __acquires(&pool->lock)
>  	 * stop_machine. At the same time, report a quiescent RCU state so
>  	 * the same condition doesn't freeze RCU.
>  	 */
> -	rcu_note_voluntary_context_switch(current);
> -	cond_resched();
> +	cond_resched_rcu_qs();
> 
>  	spin_lock_irq(&pool->lock);
> 
> -- 
> 1.7.10.4
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/