Re: [PATCH 1/1] Cpufreq: Keep cpufreq sysfs nodes across S2RAM/S2DISK when using intel_pstate driver.
From: Lan Tianyu
Date: Wed Oct 08 2014 - 02:53:09 EST
Sorry later response and just back from vacation.
On 2014å09æ29æ 16:20, Viresh Kumar wrote:
> But this change is buggy.. Because you are updating 'cpufreq_suspended'
> before actually stopping the governor, any calls to __cpufreq_governor()
> will be converted to NO-operations because of this in __cpufreq_governor():
> /* Don't start any governor operations if we are entering suspend */
> if (cpufreq_suspended)
> return 0;
> And so the governor's will never stop :(
> So you need to keep the above line where it was :)
Yes, you are right. Thanks for fixing it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/