Re: [PATCH] Input: adp5588-keys: cancel workqueue in failure path

From: Pramod Gurav
Date: Wed Oct 08 2014 - 06:25:51 EST

On Wed, Oct 8, 2014 at 3:48 PM, Pramod Gurav <pramod.gurav.etc@xxxxxxxxx> wrote:
> Hi Dmitry,
> On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov


> Thanks. I saw the change in your tree. Shouldn't
> cancel_delayed_work_sync(&kpad->work) be called under label
> err_free_mem so that it will executed in case adp5588_read,
> input_register_device, request_irq etc.
> Or else we will still have workqueue instance hanging around.

Sorry, Should have read Michael's reply more carefully. I get the
reason behind cancelling workquequq after freeing irq.

Thanks and Regards
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at