Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

From: Scott Branden
Date: Wed Oct 08 2014 - 07:17:36 EST

On 14-10-08 01:11 AM, Russell King - ARM Linux wrote:
On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote:
+static void __init bcm_cygnus_init(void)
+ of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+ l2x0_of_init(0, ~0UL);

Please don't explicitly call l2x0 initialisation. Instead, set the
appropriate l2c members here:

+ .init_machine = bcm_cygnus_init,
+ .map_io = debug_ll_io_init,
+ .dt_compat = bcm_cygnus_dt_compat,
+ .restart = bcm_cygnus_restart

and let the core code call it at the appropriate time. Thanks.

Thanks - was unaware of this functionality. Will add .l2c_aux_val and .l2c_aux mask to DT_MATCHINE_START. BUT, what happens when we need to add trustzone support and make SMC call to secure monitor?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at