Re: [PATCH v4 18/29] nios2: Signal handling support

From: Richard Weinberger
Date: Wed Oct 08 2014 - 07:29:39 EST


On Wed, Oct 8, 2014 at 11:29 AM, Ley Foon Tan <lftan@xxxxxxxxxx> wrote:
> This patch adds support for signal handling.
>
> Signed-off-by: Ley Foon Tan <lftan@xxxxxxxxxx>

Maybe I'm misreading your code but where do you check for multiple
pending signals?
It looks like you're handling only exact one signal before retuning to
userspace.
This is a serious issue, if you post a SIGSEGV i.e. in
do_rt_sigreturn() you need to handle it later
instead of directly returning to userspace.

--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/