Re: [PATCH] regulator: rk808: Add support setting suspend voltage

From: Mark Brown
Date: Wed Oct 08 2014 - 08:50:19 EST

On Tue, Oct 07, 2014 at 10:48:41AM -0700, Doug Anderson wrote:
> On Tue, Oct 7, 2014 at 1:43 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> > support setting suspend voltage and disable regulator in suspend.

Doug, please delete unneeded context from mails, paging through screen
after screen of irrelevant text on the off chance of finding content
gets old fast so it's likely that some or all what you're saying will be
missed either through boredone or error.

> One point of curiosity (maybe this is a question for Chanwoo and
> Javier): I'd expect that if someone didn't explicitly setup a "suspend
> voltage" that their voltage would just be left alone at suspend time.

No, this is not the case. The suspend mode settings are a completely
different set of settings activated when the system goes into suspend
with explicit hardware support. If no configuration for this mode is
provided then

> I believe that won't be the case for your driver. The rk808 will (I
> think) automatically transition to the "suspend voltage" settings for
> ALL regulators at suspend time. If you didn't explicitly set the
> suspend voltage then you'll move to whatever the default voltage is,
> right?

As ever the hardware configuration won't be touched by the kernel unless
it's explicitly told to do something.

Attachment: signature.asc
Description: Digital signature