Re: [PATCH 1/5] regulator: of: Add regulator-initial-mode parse support
From: Mark Brown
Date: Wed Oct 08 2014 - 11:12:48 EST
On Wed, Oct 08, 2014 at 04:38:53PM +0200, Javier Martinez Canillas wrote:
> On 10/08/2014 04:25 PM, Mark Brown wrote:
> > That doesn't mean that the definition of those modes is something we can
> > sensibly provide in generic code, especially in a completely
> > undocumented fashion (perhaps you've done that later in the patch series
> > but bisection also applies to reviewability).
> As a general question, now that the convention is for DT binding docs to go
> in a separate patch, should the DT documentation be added before or after
> that code using these bindings is added?
It fairly obviously needs to go before so that reviewers can tell if the
code is actually implementing the binding.
Description: Digital signature