Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC

[Scott Branden]

On 14-10-08 11:12 AM, Arnd Bergmann wrote:
> On Wednesday 08 October 2014 09:27:08 Scott Branden wrote:
> > On 14-10-08 06:28 AM, Arnd Bergmann wrote:
> > > On Wednesday 08 October 2014 05:27:24 Scott Branden wrote:
> > > > > I don't think you need per-board config options. The main option
> > > > > above should be enough.
> > > > This is not a per-board config option.  This is actually a per-SoC
> > > > uArchtecture selection.  More major uArchectures will be added to the
> > > > IPROC.  Will Change comment to "Support Broadcom Cygnus SoC"
> > >
> > > Ok, sounds fine, but remove ARCH_BCM_IPROC then. There should be
> > > no need for a three-level deep hierarchy (BCM -> IPROC -> CYGNUS)
> > I do not need a 3-deep hierarchy, I need a 2-deep hierarchy for IPROC
> > and CYGNUS (and future SoCs that have IPROC Architecture in common).  I
> > can move IPROC out of the mach-bcm directory if you like a create a new
> > directory?  But it looks like the purpose of mach-bcm is to consolidate
> > all Broadcom chipsets in it?
>
> Yes, better leave it all in mach-bcm. You really shouldn't need much
> code at all that is soc specific, so adding new directories is not
> encouraged. We have some platforms that need no code at all, and on
> arm64 that is required.
>
> Isn't Northstar also IPROC? That one didn't seem to need the symbol.
Yes, Northstar is an older version of IPROC.  We may be able to 
consolidate it under the IPROC family as we upstream additional SoCs and 
drivers.  Have the commonality with ARCH_BCM_IPROC will allow this.
> Could you make ARCH_BCM_IPROC a silent symbol that is just selected
> by each SoC family specific symbol?
OK, I will make ARCH_BCM_IPROC a silent symbol.
> 	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/