Re: [PATCH 11/11] perf/x86/intel: Perform rotation on Intel CQM RMIDs

From: Matt Fleming
Date: Wed Oct 08 2014 - 16:00:09 EST


On Wed, 08 Oct, at 09:02:16PM, Thomas Gleixner wrote:
> On Wed, 8 Oct 2014, Peter Zijlstra wrote:
> > On Wed, Sep 24, 2014 at 03:04:15PM +0100, Matt Fleming wrote:
> > > + preempt_disable();
>
> < SNIP loooong code >
>
> > > + preempt_enable();
> >
> > Why is all that under preempt_disable()?
>
> To make life harder for people who care about latencies and
> deterministic behaviour perhaps?

Yeah that looks... wrong.

I'll fix that.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/