RE: [PATCH v5] mmc: dw_mmc: Add IDMAC 64-bit address mode support
From: Prabu Thangamuthu
Date: Thu Oct 09 2014 - 03:39:54 EST
Thank you for reviewing and testing our Patch.
On Wed, Oct 8, 2014 at 7:17 PM, Alim Akhtar <alim.akhtar@xxxxxxxxx > wrote:
> Hi Prabu,
> On Tue, Oct 7, 2014 at 5:17 PM, Prabu Thangamuthu
> <Prabu.T@xxxxxxxxxxxx> wrote:
> > Synopsys DW_MMC IP core supports Internal DMA Controller with 64-bit
> address mode from IP version 2.70a onwards.
> > Updated the dw_mmc driver to support IDMAC 64-bit addressing mode.
> > Tested the features in DW_MMC core v2.70a and v2.40a with HAPS-51
> setup and driver is working fine.
> > Signed-off-by: Prabu Thangamuthu <prabu.t@xxxxxxxxxxxx>
> > ---
> With a minor nit below, this looks good to me.
> So, Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Have tested this on exynos7 platform which has dw_mmc controller version
> 2.70a, Have tested this on exynos5800 Pi board and found no issue.
> So, Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> > Change log v5:
> > - Recreated the patch against linux-next as this patch is
> > required for another patch
> > http://www.spinics.net/lists/arm-kernel/msg357985.html
> yes, we are using this on exynos7 platform. Thanks for re-basing and re-
> posting .
> > + /* Set the last descriptor as the end-of-ring descriptor */
> > + p->des3 = host->sg_dma;
> > + p->des0 = IDMAC_DES0_ER;
> > + }
> > +
> > + mci_writel(host, BMOD, SDMMC_IDMAC_SWRESET);
> Any reason to use this instead of earlier use of dw_mci_idmac_reset(host)?
Thanks for pointing this. It's a typo. I will resend the patch with this modification.