Re: [PATCH v4 17/29] nios2: System calls handling

[Tobias Klauser]

On 2014-10-08 at 11:29:43 +0200, Ley Foon Tan <lftan@xxxxxxxxxx> wrote:
> This patch adds support for system calls from userspaces. It uses the
> asm-generic/unistd.h definitions with architecture spcific syscall. The sys_call_table
> is just an array defined in a C file and it contains pointers to the syscall functions.
> 
> Signed-off-by: Ley Foon Tan <lftan@xxxxxxxxxx>
> ---
>  arch/nios2/include/asm/syscall.h     |  138 ++++++++++++++++++++++++++++++++++
>  arch/nios2/include/asm/syscalls.h    |   25 ++++++
>  arch/nios2/include/uapi/asm/unistd.h |   25 ++++++
>  arch/nios2/kernel/sys_nios2.c        |   66 ++++++++++++++++
>  arch/nios2/kernel/syscall_table.c    |   29 +++++++
>  5 files changed, 283 insertions(+), 0 deletions(-)
>  create mode 100644 arch/nios2/include/asm/syscall.h
>  create mode 100644 arch/nios2/include/asm/syscalls.h
>  create mode 100644 arch/nios2/include/uapi/asm/unistd.h
>  create mode 100644 arch/nios2/kernel/sys_nios2.c
>  create mode 100644 arch/nios2/kernel/syscall_table.c
[...]
> diff --git a/arch/nios2/kernel/sys_nios2.c b/arch/nios2/kernel/sys_nios2.c
> new file mode 100644
> index 0000000..a32d7f3
> --- /dev/null
> +++ b/arch/nios2/kernel/sys_nios2.c
[...]
> +#if defined(CONFIG_FB) || defined(CONFIG_FB_MODULE)
> +#include <linux/fb.h>
> +unsigned long get_fb_unmapped_area(struct file *filp, unsigned long orig_addr,
> +		unsigned long len, unsigned long pgoff, unsigned long flags)
> +{
> +
> +	struct fb_info *info = filp->private_data;
> +
> +	return (unsigned long)info->screen_base;
> +}
> +EXPORT_SYMBOL(get_fb_unmapped_area);

get_fb_unmapped_area only used if HAVE_ARCH_FB_UNMAPPED_AREA is defined,
but this isn't the case for nios2. AFAICS the altfb driver has been
broken on nios2 for a long time anyway, so I'd suggest to just remove
this function for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/