Re: [PATCH RFT 0/8] Marvell PXA168 libphy handling and Berlin Ethernet

[Sebastian Hesselbarth]

On 10/09/2014 04:33 PM, Thomas Petazzoni wrote:
> Dear Sebastian Hesselbarth,
>
> On Thu,  9 Oct 2014 14:38:58 +0200, Sebastian Hesselbarth wrote:
>
> > This patch series deals with a removing a IP feature that can be found
> > on all currently supported Marvell Ethernet IP (pxa168_eth, mv643xx_eth,
> > mvneta). The MAC IP allows to automatically perform PHY auto-negotiation
> > without software interaction.
> >
> > However, this feature (a) fundamentally clashes with the way libphy works
> > and (b) is unable to deal with quirky PHYs that require special treatment.
> > In this series, pxa168_eth driver is rewritten to completely disable that
> > feature and properly deal with libphy provided PHYs. The other two drivers
> > are suspect to future patch sets, also removing the code related with it.
>
> Hum, in mvneta, we already disabled the automatic negotiation and use
> libphy. What makes you think the current mvneta driver is wrong in this
> respect?

I didn't check mvneta, but remember Ezequiel didn't clear all AN bits
in the barebox driver (which is based on Linux mvneta). Just mentioned
that I'll have a closer look at it.

But I agree, regarding libphy support mvneta is probably the best
already.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/