Re: [PATCH] ARM: meson: watchdog: remove magic value for reboot

[Guenter Roeck]

On Thu, Oct 09, 2014 at 09:59:16PM +0200, Carlo Caione wrote:
> This patch removes the magic value used for rebooting the board. This
> value is useless and leads to a static checker warning as reported by
> Dan Carpenter.
> 
> Signed-off-by: Carlo Caione <carlo@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/meson_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/meson_wdt.c b/drivers/watchdog/meson_wdt.c
> index 37f9f5ec..ef6a298 100644
> --- a/drivers/watchdog/meson_wdt.c
> +++ b/drivers/watchdog/meson_wdt.c
> @@ -51,7 +51,7 @@ struct meson_wdt_dev {
>  static int meson_restart_handle(struct notifier_block *this, unsigned long mode,
>  				void *cmd)
>  {
> -	u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN | 100;
> +	u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN;
>  	struct meson_wdt_dev *meson_wdt = container_of(this,
>  						       struct meson_wdt_dev,
>  						       restart_handler);
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/