Re: [PATCH] serial: of-serial: fix up PM ops on no_console_suspend

[Peter Hurley]

On 10/10/2014 02:16 AM, Jingchang Lu wrote:
>> From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx]
>> On 10/09/2014 02:10 AM, Jingchang Lu wrote:
>>> Mandatorily disabling the uart clock will cause register access hung
>>> on "no_console_suspend". This patch add condition check on it and only
>>> disable the clock with console_suspend_enabled true.
>>
>> It would be useful if the email/patch subject line said "V2", and there
>> was a changelog below.
> This is not a v2, patch "serial: of-serial: add PM suspend/resume support
> (commit 2dea53bf57783f243c892e99c10c6921e956aa7e)" has been merged into
> linux-next tree, this is a fixup on that PM ops.

Then please say so in the commit log. Something like,

Fix commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
"serial: of-serial: add PM suspend/resume support", which
disables the uart clock on suspend, but also causes a hardware
hang on register access if no_console_suspend command line option
is used.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/