Re: [PATCH] x86: Clean up stack access code in irq_32.c

[H. Peter Anvin]

That's not a justification for change.  Claiming no harm is nevessary but not sufficient.

On October 12, 2014 9:53:32 AM PDT, Chuck Ebbert <cebbert.lkml@xxxxxxxxx> wrote:
>On Sun, 12 Oct 2014 09:47:53 -0700
>"H. Peter Anvin" <hpa@xxxxxxxxx> wrote:
>
>[replying to the list this time, sigh]
>
>> We changed this to asm because the C broke some compilers.  Why are
>you changing it back?
>> 
>
>The C broke some compilers because it was using a global register
>variable. This is a local one, which the clang documentation says is
>supported. And I compiled it with clang with no problem.
>
>> On October 12, 2014 9:43:53 AM PDT, Chuck Ebbert
><cebbert.lkml@xxxxxxxxx> wrote:
>> >Use C instead of asm for accessing the stack pointer. And define
>some
>> >macros to make the code easier to understand.
>> >

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/