WTF is d_add_ci() doing with negative dentries?

From: Al Viro
Date: Sun Oct 12 2014 - 18:18:24 EST

AFAICS, if d_add_ci() ever finds a negative hashed dentry for
exact name, it's already buggered. Because right *before* that
d_add_ci() lookup for exact name would've turned valid negative.
IOW, the whole thing ought to be
found = d_hash_and_lookup(dentry->d_parent, name);
if (found) {
return found;
new = d_alloc(dentry->d_parent, name);
if (!new) {
return ERR_PTR(-ENOMEM);
found = d_splice_alias(inode, new);
if (found) {
return found;
return new;
Moreover, it might very well be better to pass dentry->d_parent instead
of dentry... Objections?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at