Re: [PATCH] CLK: TI: Remove unused includes of linux/clk-private.h

From: Tero Kristo
Date: Mon Oct 13 2014 - 08:07:28 EST


Hi Tomeu,

Please add a changelog to this patch. Also, just replace the clk-private.h includes with clk-provider.h, do not add the include to the generic header. Rest of the kernel does that where needed.

Other than that, looks good to me.

-Tero

On 10/03/2014 06:51 PM, Tomeu Vizoso wrote:
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
---
drivers/clk/ti/clk-44xx.c | 1 -
drivers/clk/ti/clk-54xx.c | 1 -
drivers/clk/ti/clk-7xx.c | 1 -
include/linux/clk/ti.h | 1 +
4 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/ti/clk-44xx.c b/drivers/clk/ti/clk-44xx.c
index 02517a8..8ea705e 100644
--- a/drivers/clk/ti/clk-44xx.c
+++ b/drivers/clk/ti/clk-44xx.c
@@ -12,7 +12,6 @@

#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>

diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
index 5e18399..e823d0b 100644
--- a/drivers/clk/ti/clk-54xx.c
+++ b/drivers/clk/ti/clk-54xx.c
@@ -12,7 +12,6 @@

#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/io.h>
#include <linux/clk/ti.h>
diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
index 62ac8f6..afd61a6 100644
--- a/drivers/clk/ti/clk-7xx.c
+++ b/drivers/clk/ti/clk-7xx.c
@@ -12,7 +12,6 @@

#include <linux/kernel.h>
#include <linux/list.h>
-#include <linux/clk-private.h>
#include <linux/clkdev.h>
#include <linux/clk/ti.h>

diff --git a/include/linux/clk/ti.h b/include/linux/clk/ti.h
index e8d8a35..ced953a 100644
--- a/include/linux/clk/ti.h
+++ b/include/linux/clk/ti.h
@@ -16,6 +16,7 @@
#define __LINUX_CLK_TI_H__

#include <linux/clkdev.h>
+#include <linux/clk-provider.h>

/**
* struct dpll_data - DPLL registers and integration data


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/