Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

[Ricardo Ribalda Delgado]

Hello Alan

>> +     spin_unlock_irqrestore(&port->lock, flags);
>
> Looks good apart from this bit.. The copy needs to go to a temporary
> before the lock is taken otherwise we may sleep on a pagefault with irqs
> off
>
> Alan

Good catch

I will fix it as you suggest.

I will give a give a couple of days for comments about the serie
"[PATCH 00/12] Handle TIOC[GS]RS485
iocts on serial_core"  Then I will resend the series including this
patch (of course, fixed)


Thanks!


-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/