Re: [PATCH 1/3] input: alps: Reset mouse before identifying it

From: Dmitry Torokhov
Date: Tue Oct 14 2014 - 02:08:43 EST


On Fri, Oct 03, 2014 at 11:47:59AM +0200, Hans de Goede wrote:
> Hi,
>
> Thanks for working on this!
>
> On 10/03/2014 11:43 AM, Pali Rohár wrote:
> > On some systems after starting computer function alps_identify() does not detect
> > dual ALPS touchpad+trackstick device correctly and detect only touchpad.
> >
> > Resetting ALPS device before identifiying it fixing this problem and both parts
> > touchpad and trackstick are detected.
> >
> > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> > Tested-by: Pali Rohár <pali.rohar@xxxxxxxxx>
>
> Looks good and seems sensible:
>
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

*sigh* I am not really happy about this, as we making boot longer and longer
for people without ALPS touchpads. It would be better if we only reset the
mouse when we knew we are dealing with ALPS, and even better if we only reset
it when we suspected that we missed trackstick. Any chance of doing this?

Thanks.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/