Re: [PATCH 3/3] spi: qup: Remove .owner field for driver

From: Mark Brown
Date: Tue Oct 14 2014 - 04:14:23 EST

On Tue, Oct 14, 2014 at 11:47:57AM +0530, Kiran Padwal wrote:
> On Monday 13 October 2014 06:39 PM, Mark Brown wrote:

> > Two problems:
> > - I'm missing patches 1 and 2.

> These patches are same like this one,
> [1]
> [2]

You should at least be sending the cover letter to everyone so that they
know what's going on.

> > - This only changes one driver but essentially every SPI driver
> > initializes .owner - why is only thi sone driver being changed?

> Nothing more intention, but just remove superfluous .owner field for drivers which
> use the module_platform_driver API, as this is overridden in
> platform_driver_register anyway.

My point is that doing a change like this to random drivers isn't great,
if you're going to do this sort of thing it is better to do it for
everything rather than making things inconsistent.

Attachment: signature.asc
Description: Digital signature