Re: [PATCH v3] mtd: ubi: Extend UBI layer debug/messaging capabilities

From: Tanya Brokhman
Date: Tue Oct 14 2014 - 08:14:58 EST

On 10/13/2014 6:59 PM, Artem Bityutskiy wrote:
On Mon, 2014-10-13 at 18:37 +0300, Artem Bityutskiy wrote:
On Mon, 2014-10-06 at 14:01 +0300, Tanya Brokhman wrote:
If there is more then one UBI device mounted, there is no way to
distinguish between messages from different UBI devices.
Add device number to all ubi layer message types.

Looks good to me, pushed to the master branch of the linux-ubifs.git
tree. Later, when the merge window is closed, I'll merge this patch to
the linux-next branch too.


sorry, I was not careful enough, I merged it and tested against the
Linuses head, it is fine.

But it does not apply the the linux-ubifs.git tree. There are conflicts.

But more importantly, you did not get the 'block.c' right. There we use
the same printing macros, but we do not have 'struct ubi_info' there at

Please, enable the R/O block layer feature and try to compile, it'll

The block driver is in 'drivers/mtd/ubi', but it is kind of a separate
driver - it does not access the internal UBI data structures.

I guess the solution would be to just use pr_* functions there instead.

CCing Ezequiel.

Please, submit a patch against the 'linux-next' branch of this tree:



Ok, will do ASAP.

Tanya Brokhman
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at