Re: [PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

From: Joe Perches
Date: Tue Oct 14 2014 - 13:16:04 EST

On Tue, 2014-10-14 at 18:40 +0200, Fabian Frederick wrote:
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

It might be clearer to use a structure for this 16 byte thing.

There's a comment bit in the code:

/* cmdreq message:
u32 type
u16 cmd
u16 parm0
u16 parm1
u16 parm2
u8 pad[4]

total: 4 + 2 + 2 + 2 + 2 + 4 = 16

It seems thought that this first u32 is actually
a series of u8s.


struct zd1201_cmdreq {
u8 type;
u8 seq;
u8 a;
u8 b;
__le16 cmd;
__le16 parm0;
__le16 parm1;
__le16 parm2;
u8 pad[4];

And does this really need to be alloc'd?


struct zd1202_cmdreq request = {};


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at