Re: [PATCH v4 4/6] ARM: rockchip: add basic smp support for rk3288

[Doug Anderson]

Kever,

On Mon, Oct 13, 2014 at 1:12 PM, Kever Yang <kever.yang@xxxxxxxxxxxxxx> wrote:
> +       /*
> +        * We need to soft reset the cpu when we turn off the cpu power domain,
> +        * or else the active processors might be stalled when the individual
> +        * processor is powered down.
> +        */
> +       if (read_cpuid_part_number() != ARM_CPU_PART_CORTEX_A9) {

I haven't done a full review of this patch, but it seems unlikely that
your uses of read_cpuid_part_number() and read_cpuid_part() in this
patch are correct.  You use both functions and in both cases compare
the results to ARM_CPU_PART_CORTEX_A9.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/