Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

[Marek Vasut]

On Tuesday, October 14, 2014 at 03:26:49 AM, Bean Huo éææ (beanhuo) wrote:
[...]

> -			dev_warn(dev, "found %s, expected %s\n",
> -				 jid->name, id->name);
> -			id = jid;
> -			info = (void *)jid->driver_data;
> +			struct flash_info *tmpinfo;
> +
> +			tmpinfo = (void *)jid->driver_data;
> +			if (tmpinfo->jedec_id != info->jedec_id ||
> +					(info->ext_id != 0 &&
> +					 tmpinfo->ext_id != info->ext_id)) {
> +				dev_warn(dev, "found %s, expected %s\n",
> +						jid->name, id->name);
> +				id = jid;
> +				info = (void *)jid->driver_data;
> +			}

Won't $info contain an undefined value in case the newly added condition isn't 
met ? The old code initialized $info to a certain value always, the new code 
does not do that.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/