Re: [PATCH 2/2] mm: verify compound order when freeing a page

From: Sasha Levin
Date: Tue Oct 14 2014 - 19:09:11 EST


On 10/14/2014 04:29 PM, David Cohen wrote:
>> + VM_BUG_ON(PageTail(page));
>> > + VM_BUG_ON(PageHead(page) && compound_order(page) != order);
> It may be too severe. AFAIU we're not talking about a fatal error.
> How about VM_WARN_ON()?

VM_BUG_ON() should catch anything which is not "supposed" to happen,
and not just the severe stuff. Unlike BUG_ON, VM_BUG_ON only gets
hit with mm debugging enabled.


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/