Re: x86: Make Atom PMC driver configurable.
From: One Thousand Gnomes
Date: Wed Oct 15 2014 - 12:20:57 EST
On Wed, 15 Oct 2014 10:59:24 -0400
Dave Jones <davej@xxxxxxxxxx> wrote:
> On Wed, Oct 15, 2014 at 09:52:45AM -0500, Felipe Balbi wrote:
> > Hi,
> > On Wed, Oct 15, 2014 at 10:46:03AM -0400, Dave Jones wrote:
> > > The Atom PMC driver is always built-in, regardless of whether
> > > the kernel being built is going to be run on an Atom (or even Intel) CPU.
> > >
> > > Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
> > >
> > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > > index f2327e88e07c..04280177c1e2 100644
> > > --- a/arch/x86/Kconfig
> > > +++ b/arch/x86/Kconfig
> > > @@ -2485,7 +2485,7 @@ config X86_DMA_REMAP
> > > depends on STA2X11
> > >
> > > config PMC_ATOM
> > > - def_bool y
> > > + tristate "Intel Atom SOC power management controller driver"
> > looks like you should still have this as default y just to make sure you
> > a simple defconfig still enables this as it did before.
> I could, but why should this be default y ? There's no real
> justification to inflict this on everyone, given atom is at best
> a niche area of x86.
Possibly because you work for an enterprise vendor. Atom is not remotely
niche to everyone else.
This really does want to be a default Y for X86 at least, although I can
see that for the enterprise market you probably don't care quite so much
right now. Without that you are going to break a lot of users
configurations in a deeply surprising way.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/