[PATCH] Fix the x86 specializations of atomic_[set|clear]_mask

From: Patrick Palka
Date: Wed Oct 15 2014 - 16:38:18 EST

This patch fixes a number of issues with these specializations:

1. The memory operand inside the asm specification is erroneously
declared read-only instead of read-write.

2. There is no reason to require the 1st operand of andl/orl to be
inside a register; the 1st operand could also be an immediate operand.
So change its specification from "r" to "ir".

3. Since addr is supposed to be an atomic_t *, the memory operand
should be addr->counter and not *addr.

4. These specializations should be inline functions instead of macros.

5. Finally, the "memory" clobbers are unnecessary, so they should be
removed. (This is in line with the other atomic functions such as
atomic_add and atomic_sub, the likes of which do not have a "memory"

Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
Cc: x86@xxxxxxxxxx
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>
Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
Cc: Pranith Kumar <bobby.prani@xxxxxxxxx>
Signed-off-by: Patrick Palka <patrick@xxxxxxxxxxxx>
arch/x86/include/asm/atomic.h | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h
index 5e5cd12..83ae239 100644
--- a/arch/x86/include/asm/atomic.h
+++ b/arch/x86/include/asm/atomic.h
@@ -219,15 +219,19 @@ static inline short int atomic_inc_short(short int *v)
return *v;

-/* These are x86-specific, used by some header files */
-#define atomic_clear_mask(mask, addr) \
- asm volatile(LOCK_PREFIX "andl %0,%1" \
- : : "r" (~(mask)), "m" (*(addr)) : "memory")
+static inline void atomic_clear_mask(int mask, atomic_t *v)
+ asm volatile(LOCK_PREFIX "andl %1, %0"
+ : "+m" (v->counter)
+ : "ir" (~mask));

-#define atomic_set_mask(mask, addr) \
- asm volatile(LOCK_PREFIX "orl %0,%1" \
- : : "r" ((unsigned)(mask)), "m" (*(addr)) \
- : "memory")
+static inline void atomic_set_mask(int mask, atomic_t *v)
+ asm volatile(LOCK_PREFIX "orl %1, %0"
+ : "+m" (v->counter)
+ : "ir" (mask));

#ifdef CONFIG_X86_32
# include <asm/atomic64_32.h>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/