Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

From: Harvey Harrison
Date: Wed Oct 15 2014 - 20:07:41 EST

On Wed, Oct 15, 2014 at 10:06 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition
> explicitly marked "weak". Several architectures provide their own
> definitions intended to override the default, but the "weak" attribute on
> the declaration applied to the arch definitions as well, so the linker
> chose one based on link order (see 10629d711ed7 ("PCI: Remove __weak
> annotation from pcibios_get_phb_of_node decl")).
> Remove the "weak" attribute from the declaration so we always prefer a
> non-weak definition over the weak one, independent of link order.
> Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add declaration to header")
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> CC: Harvey Harrison <harvey.harrison@xxxxxxxxx>

Reviewed-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>

This was likely simply an error in my patch, likely just copied the
function definition and didn't even notice the
weak annotation at the time.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at