Re: [Patch v2] x86: Make Atom PMC driver configurable.

[Dave Jones]

On Thu, Oct 16, 2014 at 11:00:35AM +0800, Li, Aubrey wrote:
 > On 2014/10/16 10:18, Dave Jones wrote:
 > > The Atom PMC driver is always built-in, regardless of whether
 > > the kernel being built is going to be run on an Atom (or even Intel) CPU.
 > > 
 > > Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
 > > Cc: One Thousand Gnomes <gnomes@xxxxxxxxxxxxxxxxxxx>
 > > Cc: aubrey.li@xxxxxxxxxxxxxxx
 > > 
 > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
 > > index f2327e88e07c..b4dfd96aeea8 100644
 > > --- a/arch/x86/Kconfig
 > > +++ b/arch/x86/Kconfig
 > > @@ -2485,7 +2485,8 @@ config X86_DMA_REMAP
 > >  	depends on STA2X11
 > >  
 > >  config PMC_ATOM
 > > -	def_bool y
 > > +	tristate "Intel Atom SOC power management controller driver"
 > 
 > PMC driver provides core function like reboot, better to change to
 > bool, or did you see a scenario it can be as a module?

All the MODULE_* stuff in arch/x86/kernel/pmc_atom.c threw me off.
It could also use a help text.  I suspect you might be in a better
position than me to write one though.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/