Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

[Sudip Mukherjee]

On Thu, Oct 16, 2014 at 03:45:44PM +0200, Takashi Iwai wrote:
> At Thu, 16 Oct 2014 11:04:34 +0800,
> Raymond Yau wrote:
<snip>
> > > > since these 2 commits:
> > > >
> > > > commit e28d713704117bca0820c732210df6075b09f13b
> > > > Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > > > Date:   Tue Jun 16 11:02:28 2009 -0700
> > > >
> > > >     printk: Add KERN_DEFAULT printk log-level
> > > >
> > > >     This adds a KERN_DEFAULT loglevel marker, for when you cannot decide
> > > >     which loglevel you want, and just want to keep an existing printk
> > > >     with the default loglevel.
> > > >
> > > >     The difference between having KERN_DEFAULT and having no log-level
> > > >     marker at all is two-fold:
> > > >
> > > >      - having the log-level marker will now force a new-line if the
> > > >        previous printout had not added one (perhaps because it forgot,
> > > >        but perhaps because it expected a continuation)
> > > >
> > > >      - having a log-level marker is required if you are printing out a
> > > >        message that otherwise itself could perhaps otherwise be mistaken
> > > >        for a log-level.
> > > >
> > > > and
> > > >
> > > > commit 5fd29d6ccbc98884569d6f3105aeca70858b3e0f
> > > > Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > > > Date:   Tue Jun 16 10:57:02 2009 -0700
> > > >
> > > >     printk: clean up handling of log-levels and newlines
> > > >
> > > >     It used to be that we would only look at the log-level in a printk()
> > > >     after explicit newlines, which can cause annoying problems when the
> > > >     previous printk() did not end with a '\n'. In that case, the
> > log-level
> > > >     marker would be just printed out in the middle of the line, and be
> > > >     seen as just noise rather than change the logging level.
> > > >
> > > >     This changes things to always look at the log-level in the first
> > > >     bytes of the printout. If a log level marker is found, it is always
> > > >     used as the log-level. Additionally, if no newline existed, one is
> > > >     added (unless the log-level is the explicit KERN_CONT marker, to
> > > >     explicitly show that it's a continuation of a previous line).
> > > >
> > > >
> > > >
> > 
> > Do the driver still need two dev_info at startup and shutdown since most
> > pci drivers won't print anything to system log when the driver is loaded or
> > unloaded ?
> 
> Definitely not needed, but the intention of this patch is to convert
> to dev_*().  There are some cleanups, but it's for removing redundant
> strings, so it's a bit different from changing the log level of the
> original code.  You can submit an additional patch to adjust the log
> levels more appropriately.
> 
sure , I will submit a separate patch for cleaning up these extra dev_info.

thanks
sudip
> 
> Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/