Re: [PATCH 1/4 linux-next] x86, msr: define msr chunksize

[H. Peter Anvin]

On 10/17/2014 01:01 PM, Fabian Frederick wrote:
> define MSR_CHUNK_SIZE instead of hard-coded value (8).
> 
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>

I don't like the name, as it isn't a "chunk" but the actual width of an MSR.

Furthermore, the last hunk is just plain wrong; the 8 there refers to
the number of registers and not to the width of an MSR.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/