Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

From: Tomas Melin
Date: Sun Oct 19 2014 - 06:14:33 EST


On Sat, Oct 18, 2014 at 9:18 PM, Mauro Carvalho Chehab
<m.chehab@xxxxxxxxxxx> wrote:
>
> The right behavior here is to enable the protocol as soon as the
> new keycode table is written by userspace.
>
> Except for LIRC and the protocol of the current table enabled is
> not a good idea because:
>
> 1) It misread the code from some other IR;
> 2) It will be just spending power without need, running
> several tasks (one for each IR type) with no reason, as the
> keytable won't match the codes for other IRs (and if it is
> currently matching, then this is a bad behavior).
>
I agree, it sounds overkill to have all protocols enabled by default.
I'll make a new patch that enables lirc but disables other protocols
during registration.

Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/