Re: [PATCH] sched/numa: fix unsafe get_task_struct() in task_numa_assign()
From: Kirill Tkhai
Date: Mon Oct 20 2014 - 05:03:32 EST
Ð ÐÑ, 19/10/2014 Ð 21:43 +0200, Oleg Nesterov ÐÐÑÐÑ:
> On 10/19, Oleg Nesterov wrote:
> >
> > Forgot to mention... Or we can make task_struct_cachep SLAB_DESTROY_BY_RCU,
> > in this case ->curr (or any other "task_struct *" ponter) can not go away
> > under rcu_read_lock(). task_numa_compare() still needs the PF_EXITING check,
> > but we do not need to recheck ->curr or probe_kernel_read().
>
> Damn, please ignore ;) we still need to recheck ->curr.
Yeah, this bug like "collect puzzle" :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/