Re: [PATCH 1/2] kprobes: introduce ARCH_HANDLES_KPROBES_ON_FTRACE

[Steven Rostedt]

On Mon, 20 Oct 2014 10:55:30 +0900
Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:


> Hmm, this looks a bit not straight. Maybe we'd better introduce a local
> check_ftrace_location() function which always returns 0 if
> CONFIG_ARCH_HANDLES_KPROBES_ON_FTRACE(with a comment! :)) as below.
> 
> int check_ftrace_location(kp)
> {
> 	unsigned long ftrace_address;
> 
> 	/* If an architecture handles kprobes on ftrace, we don't check it */
> 	if (IS_ENABLED(CONFIG_ARCH_HANDLES_KPROBES_ON_FTRACE))
> 		return 0;
> 
> 	...
> }

We can also just make that function weak, and let the archs override
the default behavior?

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/