Re: [PATCH] memcg: simplify unreclaimable groups handling in soft limit reclaim

From: Johannes Weiner
Date: Mon Oct 20 2014 - 15:00:02 EST


On Mon, Oct 20, 2014 at 07:55:54PM +0400, Vladimir Davydov wrote:
> If we fail to reclaim anything from a cgroup during a soft reclaim pass
> we want to get the next largest cgroup exceeding its soft limit. To
> achieve this, we should obviously remove the current group from the tree
> and then pick the largest group. Currently we have a weird loop instead.
> Let's simplify it.
>
> Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>

I wonder if there will be anything left once we removed all that which
is pointless and the unnecessary from the memcg code.

Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/