Re: [PATCH 1/2] binfmt_misc: add comments & debug logs

[Mike Frysinger]

On 19 Oct 2014 17:41, Joe Perches wrote:
> On Sun, 2014-10-19 at 19:03 -0400, Mike Frysinger wrote:
> > let's deploy extensive pr_debug markers at
> > logical parse points, and add comments to the dense parsing logic.
> []
> > diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
> []
> > @@ -259,14 +270,17 @@ static char * check_special_flags (char * sfs, Node * e)
> >  	while (cont) {
> >  		switch (*p) {
> >  			case 'P':
> > +				pr_debug("register: flag: P (preserve argv0)");
> 
> Missing '\n' newline.
> Can you please add them as appropriate?

hmm, guess i was relying on pr_cont behavior to do the right thing.  will do.
-mike

Attachment: signature.asc
Description: Digital signature