Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: Fix d_splice_alias() return code checking

From: Andrew Morton
Date: Mon Oct 20 2014 - 19:12:24 EST


On Sun, 19 Oct 2014 12:39:44 +0200 Richard Weinberger <richard@xxxxxx> wrote:

> d_splice_alias() can return a valid dentry, NULL or an ERR_PTR.
> Currently the code checks not for ERR_PTR and my oops in
> ocfs2_dentry_attach_lock().

It's unclear what the second sentence is trying to tell us. The patch
fixes an oops? If so, a copy of the trace would be useful, as would an
explanation of why it occurred. If not, I'm all confused.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/