Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP

From: josh
Date: Mon Oct 20 2014 - 19:45:48 EST


On Tue, Oct 21, 2014 at 06:18:00AM +0800, Greg Kroah-Hartman wrote:
> On Mon, Oct 20, 2014 at 04:55:11AM -0700, Josh Triplett wrote:
> > On Mon, Oct 20, 2014 at 11:42:31AM +0200, Johannes Berg wrote:
> > > On Thu, 2014-10-16 at 11:49 -0400, Aristeu Rozanski wrote:
> > > > It's desirable for allnconfig and tinyconfig targets to result in the
> > > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> > > > switch off DEV_COREDUMP regardless if any drivers select
> > > > WANT_DEV_COREDUMP.
> > > >
> > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> > > > 'n' (as in allnconfig or tinyconfig) will effectively disable device
> > > > coredump.
> > > >
> > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > > > Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > >
> > > Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > > Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> > >
> > > Yeah, looks sensible, and should work.
> >
> > Thanks.
> >
> > I've added this to the tiny/reverse-dev-coredump branch of my
> > tinification tree at
> > https://git.kernel.org/cgit/linux/kernel/git/josh/linux.git/ , with
> > Johannes' review, and I'll push it upstream during the 3.19 merge
> > window.
>
> I'll take it through the same tree this original came in and will get it
> into 3.18 so we don't confuse anyone with an odd config option.

Excellent, dropped from tiny then.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/