Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

[John Stultz]

On Mon, Oct 20, 2014 at 8:18 PM, Thomas Shao <huishao@xxxxxxxxxxxxx> wrote:
>
>> -----Original Message-----
>> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
>> owner@xxxxxxxxxxxxxxx] On Behalf Of Thomas Gleixner
>> Sent: Tuesday, October 21, 2014 2:41 AM
>> To: Thomas Shao
>> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; LKML; devel@xxxxxxxxxxxxxxxxxxxxxx;
>> olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; KY Srinivasan;
>> John Stultz; Richard Cochran
>> Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for
>> do_adjtimex()
>>
>> On Mon, 20 Oct 2014, Thomas Gleixner wrote:
>>
>> > On Wed, 15 Oct 2014, Thomas Shao wrote:
>> >
>> > And again you forgot to cc John Stultz on this....
>> >
>> > > Export do_adjtimex function for hyper-v Time Synchronization
>> > > component
>>
>> Aside of that, we really want to see the use case for this and how you
>> addressed the problems which were pointed out by various folks.
>>
>
> In some situation, the user is not able to enable guest VM to sync with external
> time source, like NTP. But the host is still synced with a trusted time source.
> In this case, host-guest time synchronization is useful. Hyper-v host will send time
> sample to guest VM every 5 seconds. We will use these time samples to adjust guest
> VM time.
>
> I've got some feedbacks from Richard and Mike, including reference NTP implementation
> and do the adjustment in the host side. I've already referenced some NTP design in
> my patch. I would consider my patch as a simplified implementation. I've also considered
> the host side implementation. But in host, we can only set time but not gradually slew/adjust
> time, which is not acceptable for the time sync solution.We still recommend user to configure
> NTP on the guest, which provides better accuracy. But if NTP is not applicable, this could be
> another option.
>
>> I still do not have a consistent argument from you WHY you need to abuse
>> do_adjtimex() to do that host - guest synchronization in the first place.
>>
>
> I need a function to gradually slew guest time. do_adjtimex() provides all the
> functionality. Also I could not find any other exposed func to do this. I'd like to
> hear any feedback from you for this.

Do you have any protections from both your kernel module trying to
slew time if the guest is also running NTPd? That seems like it could
cause some strange behavior.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/