Re: [PATCH 8/9] ARM: berlin: Add phy-connection-type to BG2Q PHY

[Sebastian Hesselbarth]

On 21.10.2014 13:31, Sergei Shtylyov wrote:
> Hello.
>
> On 10/21/2014 12:53 PM, Sebastian Hesselbarth wrote:
>
> > From: Antoine TÃnart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
>
> > Internal FastEthernet PHY on BG2Q is connected via MII, add a
> > corresponding phy-connection-type property.
>
> > Tested-by: Antoine TÃnart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> > ---
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: "Antoine TÃnart" <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > Cc: Eric Miao <eric.y.miao@xxxxxxxxx>
> > Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> >   arch/arm/boot/dts/berlin2q.dtsi | 1 +
> >   1 file changed, 1 insertion(+)
>
> > diff --git a/arch/arm/boot/dts/berlin2q.dtsi
> > b/arch/arm/boot/dts/berlin2q.dtsi
> > index 891d56b03922..6dbc520bddc1 100644
> > --- a/arch/arm/boot/dts/berlin2q.dtsi
> > +++ b/arch/arm/boot/dts/berlin2q.dtsi
> > @@ -127,6 +127,7 @@
> >               status = "disabled";
> >
> >               ethphy0: ethernet-phy@0 {
> > +                phy-connection-type = "mii";
>
>     You're adding this prop to the PHY node? That's very weird...
> normally, it's a property of a MDIO bus node.

Sergei,

How can this be a property of the MDIO bus node? Just think of an MDIO
bus with two PHYs where one is connected via GMII and the other via
RGMII? How should this work?

But you are right that the property should not be part of the PHY node
but the controller node instead. I'll rework and send an update, thanks
for the hint.

Sebastian


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/