Re: [PATCH 2/2] sched/deadline: don't need to balance during wakeup if wakee is pinned
From: Juri Lelli
Date: Tue Oct 21 2014 - 09:42:45 EST
On 21/10/14 14:39, Wanpeng Li wrote:
> Hi Juri,
>
> ä 10/21/14, 9:29 PM, Juri Lelli åé:
>> Hi,
>>
>> On 21/10/14 13:19, Wanpeng Li wrote:
>>> Cc Juri,
>>>
>>> ä 10/14/14, 10:22 AM, Wanpeng Li åé:
>>>> Use nr_cpus_allowed to bail from select_task_rq() when only one cpu
>>>> can be used, and saves some cycles for pinned tasks.
>>>>
>>>> Signed-off-by: Wanpeng Li <wanpeng.li@xxxxxxxxxxxxxxx>
>>>> ---
>>>> kernel/sched/deadline.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
>>>> index f46b7f1..5874bf8 100644
>>>> --- a/kernel/sched/deadline.c
>>>> +++ b/kernel/sched/deadline.c
>>>> @@ -914,6 +914,9 @@ select_task_rq_dl(struct task_struct *p, int cpu, int sd_flag, int flags)
>>>> struct task_struct *curr;
>>>> struct rq *rq;
>>>>
>>>> + if (p->nr_cpus_allowed == 1)
>>>> + goto out;
>>>> +
>>>> if (sd_flag != SD_BALANCE_WAKE)
>>>> goto out;
>>>>
>> Apart from the encoding of the resend, it looks good, thanks!
>
> What's your meaning of resend? Do you mean this one?
Nope. I just meant that I received your "Cc Juri" encoded as Chinese
Simplified. But, I guess the original lkml patch looks good. Sorry for
the confusion :).
Best,
- Juri
>
> https://lkml.org/lkml/2014/10/10/425
>
> I'm afraid they are different patches.
>
> Regards,
> Wanpeng Li
>
>>
>> Best,
>>
>> - Juri
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/